yl09099 commented on code in PR #938:
URL: https://github.com/apache/incubator-uniffle/pull/938#discussion_r1223814023
##########
coordinator/src/main/java/org/apache/uniffle/coordinator/SimpleClusterManager.java:
##########
@@ -121,35 +129,39 @@ public SimpleClusterManager(CoordinatorConf conf,
Configuration hadoopConf) thro
void nodesCheck() {
try {
long timestamp = System.currentTimeMillis();
- Set<String> deleteIds = Sets.newHashSet();
- Set<String> unhealthyNode = Sets.newHashSet();
for (ServerNode sn : servers.values()) {
Review Comment:
Thank you for your suggestion, but I think there is already a losted list
field, unhealthy to become a field will make the code more uniform, and if we
go through hundreds of ServerNodes to find a few unhealthy ServerNodes, the
cost is greater than storing one field
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
