xianjingfeng commented on code in PR #938:
URL: https://github.com/apache/incubator-uniffle/pull/938#discussion_r1222764120
##########
coordinator/src/main/java/org/apache/uniffle/coordinator/SimpleClusterManager.java:
##########
@@ -231,6 +243,24 @@ public List<ServerNode> getServerList(Set<String>
requiredTags) {
return availableNodes;
}
+ @Override
+ public List<ServerNode> getLostedServerList() {
+ List<ServerNode> lostedNodesList = Lists.newArrayList();
+ for (ServerNode lostNode : lostNodes) {
+ lostedNodesList.add(lostNode);
Review Comment:
Why we need create a new list?
##########
coordinator/src/main/java/org/apache/uniffle/coordinator/SimpleClusterManager.java:
##########
@@ -231,6 +243,24 @@ public List<ServerNode> getServerList(Set<String>
requiredTags) {
return availableNodes;
}
+ @Override
+ public List<ServerNode> getLostedServerList() {
+ List<ServerNode> lostedNodesList = Lists.newArrayList();
+ for (ServerNode lostNode : lostNodes) {
+ lostedNodesList.add(lostNode);
+ }
+ return lostedNodesList;
+ }
+
+ @Override
+ public List<ServerNode> getUnhealthyServerList() {
+ List<ServerNode> unhealthyNodesList = Lists.newArrayList();
+ for (ServerNode lostNode : unhealthyNodes) {
+ unhealthyNodesList.add(lostNode);
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
