yl09099 commented on code in PR #938:
URL: https://github.com/apache/incubator-uniffle/pull/938#discussion_r1222623440
##########
coordinator/src/main/java/org/apache/uniffle/coordinator/SimpleClusterManager.java:
##########
@@ -64,6 +64,14 @@ public class SimpleClusterManager implements ClusterManager {
private final Map<String, ServerNode> servers = JavaUtils.newConcurrentMap();
private final Cache<ServerNode, ShuffleServerInternalGrpcClient> clientCache;
private Set<String> excludeNodes = Sets.newConcurrentHashSet();
+ /**
+ * ServerNode whose heartbeat is lost
+ */
+ Set<ServerNode> lostNodes = Sets.newHashSet();
Review Comment:
I understand that this thing needs to be manually confirmed before removal,
and I plan to mention another PR later on to remove the lost serverNode through
CLI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
