zhengchenyu commented on code in PR #1121:
URL:
https://github.com/apache/incubator-uniffle/pull/1121#discussion_r1289496173
##########
common/src/test/java/org/apache/uniffle/common/RemoteStorageInfoTest.java:
##########
@@ -119,4 +119,14 @@ public void testHashCode() {
RemoteStorageInfo info1 = new RemoteStorageInfo(TEST_PATH, CONF_STRING);
assertEquals(info.hashCode(), info1.hashCode());
}
+
+ @ParameterizedTest
+ @ValueSource(strings = {"k1=v1\\,v11,k2=v2\\,v22"})
Review Comment:
Yes, we should add document. I will do it later...
Do you means that?
```
key1=value1,value11;key2=value2
```
or
```
cluster;key1=value1,value11;key2=value2
```
I am not sure about it. Because I think ';' may include in config value; For
example:
```
<property>
<name>hadoop.user.group.static.mapping.overrides</name>
<value>dr.who=;hdfs=supergroup,hdfs,hadoop</value>
</property>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
