zhengchenyu commented on code in PR #1121:
URL:
https://github.com/apache/incubator-uniffle/pull/1121#discussion_r1289498762
##########
common/src/test/java/org/apache/uniffle/common/RemoteStorageInfoTest.java:
##########
@@ -119,4 +119,14 @@ public void testHashCode() {
RemoteStorageInfo info1 = new RemoteStorageInfo(TEST_PATH, CONF_STRING);
assertEquals(info.hashCode(), info1.hashCode());
}
+
+ @ParameterizedTest
+ @ValueSource(strings = {"k1=v1\\,v11,k2=v2\\,v22"})
+ public void testParseReservedSymbo(String confString) {
Review Comment:
It is hard to find a splitter which is not conflict with remote storage
config.
Why I use '\\', because it is java escape character, I think no projects
will use '\\' as splitter.
I think the best way is that we should import a remote storage configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
