LuciferYang commented on code in PR #1121:
URL:
https://github.com/apache/incubator-uniffle/pull/1121#discussion_r1289715157
##########
common/src/test/java/org/apache/uniffle/common/RemoteStorageInfoTest.java:
##########
@@ -119,4 +119,14 @@ public void testHashCode() {
RemoteStorageInfo info1 = new RemoteStorageInfo(TEST_PATH, CONF_STRING);
assertEquals(info.hashCode(), info1.hashCode());
}
+
+ @ParameterizedTest
+ @ValueSource(strings = {"k1=v1\\,v11,k2=v2\\,v22"})
Review Comment:
s this an Improvement or a bug fix? In
https://github.com/apache/incubator-uniffle/issues/1110, I saw that its title
is an `[Improvement]`, but in the description, `Describe the bug` is filled in,
which seems a bit ambiguous.
##########
common/src/test/java/org/apache/uniffle/common/RemoteStorageInfoTest.java:
##########
@@ -119,4 +119,14 @@ public void testHashCode() {
RemoteStorageInfo info1 = new RemoteStorageInfo(TEST_PATH, CONF_STRING);
assertEquals(info.hashCode(), info1.hashCode());
}
+
+ @ParameterizedTest
+ @ValueSource(strings = {"k1=v1\\,v11,k2=v2\\,v22"})
Review Comment:
Is this an Improvement or a bug fix? In
https://github.com/apache/incubator-uniffle/issues/1110, I saw that its title
is an `[Improvement]`, but in the description, `Describe the bug` is filled in,
which seems a bit ambiguous.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
