LuciferYang commented on code in PR #1121:
URL:
https://github.com/apache/incubator-uniffle/pull/1121#discussion_r1289753568
##########
docs/coordinator_guide.md:
##########
@@ -92,7 +92,7 @@ This document will introduce how to deploy Uniffle
coordinators.
|rss.coordinator.dynamicClientConf.enabled|false| whether to enable dynamic
client conf, which will be fetched by spark client
|
|rss.coordinator.dynamicClientConf.path|-| The dynamic client conf of this
cluster and can be stored in HADOOP FS or local
|
|rss.coordinator.dynamicClientConf.updateIntervalSec|120| The dynamic client
conf update interval in seconds
|
-|rss.coordinator.remote.storage.cluster.conf|-| Remote Storage Cluster related
conf with format $clusterId,$key=$value, separated by ';'
|
+|rss.coordinator.remote.storage.cluster.conf|-| Remote Storage Cluster related
conf with format $clusterId,$key=$value, separated by ';'. If $value contain
',' or '=', you can add '\\' before it. For example:
$clusterId,$key=$value1\\,$value2
|
Review Comment:
https://github.com/apache/incubator-uniffle/blob/0bde6ba30f59060e52a0b857c96538780c05db7b/coordinator/src/main/java/org/apache/uniffle/coordinator/CoordinatorConf.java#L145-L150
Does it also need to be fixed here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
