yl09099 commented on code in PR #1141:
URL:
https://github.com/apache/incubator-uniffle/pull/1141#discussion_r1368075820
##########
client-spark/spark3/src/main/java/org/apache/spark/shuffle/writer/RssShuffleWriter.java:
##########
@@ -109,7 +113,10 @@ public RssShuffleWriter(
RssShuffleManager shuffleManager,
SparkConf sparkConf,
ShuffleWriteClient shuffleWriteClient,
- RssShuffleHandle<K, V, C> rssHandle) {
+ RssShuffleHandle<K, V, C> rssHandle,
+ ShuffleHandleInfo shuffleHandleInfo,
+ TaskContext context,
+ ShuffleManagerClient shuffleManagerClient) {
Review Comment:
> @yl09099 Why change this constructor to add TaskContext and
ShuffleManagerClient?
> TaskContext
ShuffleManagerClient has been removed, from which TaskContext's later PR
needs to obtain information such as Stage AttemptNumber.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
