jerqi commented on code in PR #1141:
URL: 
https://github.com/apache/incubator-uniffle/pull/1141#discussion_r1368081125


##########
client-spark/spark2/src/main/java/org/apache/spark/shuffle/RssShuffleManager.java:
##########
@@ -710,4 +754,42 @@ public Map<Long, List<ShuffleServerInfo>> 
getFailedBlockIdsWithShuffleServer(Str
     }
     return result;
   }
+
+  @Override
+  public ShuffleHandleInfo getShuffleHandleInfoByShuffleId(int shuffleId) {
+    return shuffleIdToShuffleHandleInfo.get(shuffleId);
+  }
+
+  private ShuffleManagerClient createShuffleManagerClient(String host, int 
port) {
+    // host is passed from spark.driver.bindAddress, which would be set when 
SparkContext is

Review Comment:
   ```
   Host can be inferred from `spark.driver.bindAddress`
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to