jerqi commented on code in PR #1141:
URL:
https://github.com/apache/incubator-uniffle/pull/1141#discussion_r1368096505
##########
client-spark/spark2/src/main/java/org/apache/spark/shuffle/RssShuffleManager.java:
##########
@@ -107,6 +114,14 @@ public class RssShuffleManager extends
RssShuffleManagerBase {
private final Map<Integer, Integer> shuffleIdToNumMapTasks =
Maps.newConcurrentMap();
private GrpcServer shuffleManagerServer;
private ShuffleManagerGrpcService service;
+ private ShuffleManagerClient shuffleManagerClient;
+ /**
+ * Mapping between ShuffleId and ShuffleServer list. ShuffleServer list is
dynamically allocated.
+ * ShuffleServer is not obtained from RssShuffleHandle, but from this
mapping.
+ */
+ private Map<Integer, ShuffleHandleInfo> shuffleIdToShuffleHandleInfo =
Maps.newConcurrentMap();
Review Comment:
Should we use `JavaUtils.newConcurrentMap`?
##########
client-spark/spark2/src/main/java/org/apache/spark/shuffle/RssShuffleManager.java:
##########
@@ -107,6 +114,14 @@ public class RssShuffleManager extends
RssShuffleManagerBase {
private final Map<Integer, Integer> shuffleIdToNumMapTasks =
Maps.newConcurrentMap();
Review Comment:
ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
