yl09099 commented on code in PR #1141:
URL:
https://github.com/apache/incubator-uniffle/pull/1141#discussion_r1368077622
##########
client-spark/spark3/src/main/java/org/apache/spark/shuffle/writer/RssShuffleWriter.java:
##########
@@ -109,7 +113,10 @@ public RssShuffleWriter(
RssShuffleManager shuffleManager,
SparkConf sparkConf,
ShuffleWriteClient shuffleWriteClient,
- RssShuffleHandle<K, V, C> rssHandle) {
+ RssShuffleHandle<K, V, C> rssHandle,
+ ShuffleHandleInfo shuffleHandleInfo,
+ TaskContext context,
+ ShuffleManagerClient shuffleManagerClient) {
Review Comment:
> Is it possible to put shuffleHandleInfo into rssHandle? This will make the
code cleaner. @yl09099
To put shuffleHandleInfo object into the broadcast on the Driver side, if
you want to put shuffleHandleInfo into rssHandle, you need to build RPC
interface through the Driver's broadcast object to put in, here I think it is a
waste of performance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
