lifeSo commented on code in PR #1400:
URL:
https://github.com/apache/incubator-uniffle/pull/1400#discussion_r1439367080
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServer.java:
##########
@@ -193,6 +194,7 @@ public void stopServer() throws Exception {
if (executorService != null) {
executorService.shutdownNow();
}
+ shuffleTaskManager.stop();
Review Comment:
shuffleTaskManager is assigned in constructor and initialization() method.
I added the null check to make code more robustness
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
