lifeSo commented on code in PR #1400:
URL:
https://github.com/apache/incubator-uniffle/pull/1400#discussion_r1439410707
##########
server/src/main/java/org/apache/uniffle/server/ShuffleTaskInfo.java:
##########
@@ -42,15 +42,19 @@ public class ShuffleTaskInfo {
private final String appId;
private Long currentTimes;
/** shuffleId -> commit count */
- private Map<Integer, AtomicInteger> commitCounts;
+ private final Map<Integer, AtomicInteger> commitCounts;
- private Map<Integer, Object> commitLocks;
+ private final Map<Integer, Object> commitLocks;
/** shuffleId -> blockIds */
- private Map<Integer, Roaring64NavigableMap> cachedBlockIds;
+ private final Map<Integer, Roaring64NavigableMap> cachedBlockIds;
private AtomicReference<String> user;
- private AtomicLong totalDataSize = new AtomicLong(0);
+ private final AtomicLong totalDataSize = new AtomicLong(0);
+ private final AtomicLong totalDataSizeInMemory = new AtomicLong(0);
+ private final AtomicLong totalDataSizeOnDisk = new AtomicLong(0);
+ private final AtomicLong totalDataSizeRemote = new AtomicLong(0);
Review Comment:
change to hadoop is ok, but if use obs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
