lifeSo commented on code in PR #1400:
URL:
https://github.com/apache/incubator-uniffle/pull/1400#discussion_r1439395733
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerMetrics.java:
##########
@@ -111,6 +111,11 @@ public class ShuffleServerMetrics {
private static final String TOTAL_REMOVE_RESOURCE_BY_SHUFFLE_IDS_TIME =
"total_remove_resource_by_shuffle_ids_time";
+ private static final String TOP_N_TOTAL_SHUFFLE_DATA =
"top_N_total_shuffle_data";
Review Comment:
> this all metrics newly introduced are not consistent with their names.
>
> I think the
>
> `topN_of_total_data_size_for_app` `topN_of_on_memory_data_size_for_app`
`topN_of_on_localfile_data_size_for_app` `topN_of_on_hadoop_data_size_for_app`
>
> How about this?
Ok, I change to it. it is more clear
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
