lifeSo commented on code in PR #1400:
URL:
https://github.com/apache/incubator-uniffle/pull/1400#discussion_r1441191744
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerConf.java:
##########
@@ -538,6 +538,19 @@ public class ShuffleServerConf extends RssBaseConf {
+ "network_bandwidth = 10Gbps, buffer size should be ~
1.25MB."
+ "Default is 0, OS will dynamically adjust the buf size.");
+ public static final ConfigOption<Integer>
SERVER_SHUFFLE_DATA_METRIC_TOP_NUMBER =
+ ConfigOptions.key("rss.server.shuffle.data.metric.top.number")
Review Comment:
Ok， I changed the code like this:
```
public static final ConfigOption<Integer>
SERVER_SHUFFLE_DATA_METRIC_TOP_NUMBER =
ConfigOptions.key("rss.server.shuffle.data.metric.top.number")
.intType()
.defaultValue(10)
.withDescription(
"size of topN when calc max shuffle data in memory、on
disk、remote HDFS or total.");
public static final ConfigOption<Integer>
SERVER_SHUFFLE_DATA_METRIC_REFRESH_INTERVAL =
ConfigOptions.key("rss.server.shuffle.data.metric.refresh.interval")
.intType()
.defaultValue(1000)
.withDescription("Shuffle data metric refresh interval in ms");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
