lifeSo commented on code in PR #1400:
URL:
https://github.com/apache/incubator-uniffle/pull/1400#discussion_r1442824723
##########
server/src/main/java/org/apache/uniffle/server/ShuffleTaskManager.java:
##########
@@ -833,4 +853,47 @@ private void triggerFlush() {
this.shuffleBufferManager.flushIfNecessary();
}
}
+
+ public List<Map.Entry<String, ShuffleTaskInfo>>
calcTopNTotalDataSizeTaskInfo() {
Review Comment:
I original want to encapsulate shuffleTaskInfos in ShuffleTaskManager.
If do as what you say, shuffleTaskInfos will be public through get method().
I will modify the code to your idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
