jerqi commented on code in PR #1528:
URL:
https://github.com/apache/incubator-uniffle/pull/1528#discussion_r1510851019
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerGrpcService.java:
##########
@@ -528,6 +529,11 @@ public void getShuffleResult(
String appId = request.getAppId();
int shuffleId = request.getShuffleId();
int partitionId = request.getPartitionId();
+ BlockIdLayout blockIdLayout =
Review Comment:
We can use `BlockIdLayout.DEFAULT` if layout is null. We can't guarantee the
compatibility if users modify our code in the project.
##########
common/src/main/java/org/apache/uniffle/common/segment/FixedSizeSegmentSplitter.java:
##########
@@ -84,11 +83,10 @@ private static List<ShuffleDataSegment>
transIndexDataToSegments(
if (dataFileLen != -1 && totalLength > dataFileLen) {
LOGGER.info(
"Abort inconsistent data, the data length: {}(bytes) recorded in
index file is greater than "
- + "the real data file length: {}(bytes). Partition id: {}. "
+ + "the real data file length: {}(bytes). "
+ "This may happen when the data is flushing, please
ignore.",
totalLength,
- dataFileLen,
- BlockId.getPartitionId(blockId));
Review Comment:
ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
