zuston commented on code in PR #1528:
URL:
https://github.com/apache/incubator-uniffle/pull/1528#discussion_r1513992342
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerGrpcService.java:
##########
@@ -528,6 +529,15 @@ public void getShuffleResult(
String appId = request.getAppId();
int shuffleId = request.getShuffleId();
int partitionId = request.getPartitionId();
+ BlockIdLayout blockIdLayout = BlockIdLayout.DEFAULT;
+ // legacy clients might send request without block id layout, we fall back
to DEFAULT then
Review Comment:
> We don't need to guarantee the new client connect the old shuffle server
correctly. We don't consider the compatible issue in the other features.
But this will effect data correctness if someone missed this when upgrading
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
