LuciferYang commented on code in PR #2387:
URL: https://github.com/apache/uniffle/pull/2387#discussion_r1990457974
##########
integration-test/common/src/test/java/org/apache/uniffle/test/AssignmentWithTagsTest.java:
##########
@@ -78,65 +80,45 @@ private static List<Integer> findAvailablePorts(int num)
throws IOException {
return ports;
}
- private static void createAndStartShuffleServerWithTags(Set<String> tags,
File tmpDir)
- throws Exception {
- ShuffleServerConf shuffleServerConf =
getShuffleServerConf(ServerType.GRPC);
+ private static void prepareShuffleServerConf(int subDirIndex, Set<String>
tags, File tmpDir) {
+ ShuffleServerConf shuffleServerConf =
+ shuffleServerConfWithoutPort(subDirIndex, tmpDir, ServerType.GRPC);
Review Comment:
with this pr, some test helper methods will become unused. Could you please
clean them up together in current one? such as
`AssignmentWithTagsTest#findAvailablePorts`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
