summaryzb commented on code in PR #2387:
URL: https://github.com/apache/uniffle/pull/2387#discussion_r1990664321
##########
integration-test/common/src/test/java/org/apache/uniffle/test/CoordinatorGrpcTest.java:
##########
@@ -141,31 +138,28 @@ public void getShuffleRegisterInfoTest() {
}
@Test
- public void getShuffleAssignmentsTest() throws Exception {
+ public void getShuffleAssignmentsTest(@TempDir File tmpDir) throws Exception
{
final String appId = "getShuffleAssignmentsTest";
CoordinatorTestUtils.waitForRegister(coordinatorClient, 2);
- // When the shuffleServerHeartbeat Test is completed before the current
test,
- // the server's tags will be [ss_v4, GRPC_NETTY] and [ss_v4, GRPC],
respectively.
- // We need to remove the first machine's tag from GRPC_NETTY to GRPC
+
grpcShuffleServers.get(0).stopServer();
- RssConf shuffleServerConf =
grpcShuffleServers.get(0).getShuffleServerConf();
- Class<RssConf> clazz = RssConf.class;
- Field field = clazz.getDeclaredField("settings");
- field.setAccessible(true);
- ((ConcurrentHashMap<Object, Object>) field.get(shuffleServerConf))
- .remove(ShuffleServerConf.NETTY_SERVER_PORT.key());
+ List<Integer> ports = reserveJettyPorts(1);
+ ShuffleServerConf shuffleServerConf = shuffleServerConfWithoutPort(0,
tempDir, ServerType.GRPC);
Review Comment:
Good catch, my bad
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
