LuciferYang commented on code in PR #2387:
URL: https://github.com/apache/uniffle/pull/2387#discussion_r1990483913
##########
integration-test/common/src/test/java/org/apache/uniffle/test/IntegrationTestBase.java:
##########
@@ -144,10 +170,14 @@ public static void startServersWithRandomPorts() throws
Exception {
protected static List<Integer> jettyPorts = Lists.newArrayList();
- public static void reserveJettyPorts(int numPorts) {
+ public static List<Integer> reserveJettyPorts(int numPorts) {
+ ArrayList<Integer> ports = new ArrayList<>(numPorts);
Review Comment:
Nit: List<Integer> ports = new ArrayList<>(numPorts);
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
