summaryzb commented on code in PR #2387:
URL: https://github.com/apache/uniffle/pull/2387#discussion_r1990647226
##########
integration-test/common/src/test/java/org/apache/uniffle/test/CoordinatorGrpcTest.java:
##########
@@ -303,20 +297,26 @@ public void shuffleServerHeartbeatTest() throws Exception
{
assertEquals(StorageStatus.NORMAL, infoHead.getStatus());
assertTrue(node.getTags().contains(Constants.SHUFFLE_SERVER_VERSION));
assertTrue(scm.getTagToNodes().get(Constants.SHUFFLE_SERVER_VERSION).contains(node));
- ShuffleServerConf shuffleServerConf =
getShuffleServerConf(ServerType.GRPC);
+
+ List<Integer> ports = reserveJettyPorts(1);
+ ShuffleServerConf shuffleServerConf = shuffleServerConfWithoutPort(0,
tempDir, ServerType.GRPC);
Review Comment:
Previous test use a tempDir in `IntegrationTestBase` which is never changed
and share across all tests, it's better to use a separate dir.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
