[
https://issues.apache.org/jira/browse/YUNIKORN-418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17250458#comment-17250458
]
Manikandan R commented on YUNIKORN-418:
---------------------------------------
Making dry_run as true by default is equivalent to ws/v1/config. In general
understanding,
1. Calling ws/v1/config gives the impression that it creates the config (which
we don't want)
2. dry_run is something which requires explicit consent from users.
With this, I think asking users to explicitly pass dry_run=1 query param always
(till we support config creation through this API) seems to be cleaner one.
Thoughts?
So far, we return errors in plain text response format. Have added middleware
(wrapper on response writer) to ensure REST API's return errors also in JSON
format. Added this support to comply with REST design principles.
[~wwei] If we can quickly review and merge this, I can use the middleware for
other re-designed API's as well.
> Add "config" REST API
> ---------------------
>
> Key: YUNIKORN-418
> URL: https://issues.apache.org/jira/browse/YUNIKORN-418
> Project: Apache YuniKorn
> Issue Type: Sub-task
> Reporter: Manikandan R
> Assignee: Manikandan R
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
