[
https://issues.apache.org/jira/browse/YUNIKORN-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540847#comment-17540847
]
Wilfred Spiegelenburg commented on YUNIKORN-1213:
-------------------------------------------------
I am a hard *-1* on making any of these config changes without a full design
etc.
There are a number of issues with making it one config. The configuration is
backed by a config map. The config map is written from the REST call and is
fully mutable, i.e. gets replaced with the new config NOT updated. The update
was always based on the fact that we update the partitions and the queues
included. With the queue complexity in mind we have not allowed for partial
updates. Never has there be any consideration that the config has any are other
details than the queues. Without a solution for this any change is a no-go.
When we add new values or parts to the config, how are we now going to handle
an update call now? Does the caller need to provide a full object with all
values set? The other option would be that we are going to merge new with
existing config values. Do we assume that all values that are not given in the
configuration get retrieved from the current config and then merged and written
into the file? Do we omit the defaults etc.
Are all values that we need to have in the config mutable already or are there
certain values that we do not want to ever make mutable as they require a
restart.
The simple change of moving the checksum around in the config is already
backwards incompatible. You MUST not rely on the fact that everyone uses our
config objects to generate a REST request. It is only available in go, what if
I use java.
We logged YUNIKORN-455 a long time ago to make the scheduler configurable that
is still open. The mention of two files is already there. Looking back over
jiras I think we have at least 6 or 7 parameters that need to be configurable.
Looking forward I can think of a couple more that will come.
> The interval of the background health checker needs to be configurable
> ----------------------------------------------------------------------
>
> Key: YUNIKORN-1213
> URL: https://issues.apache.org/jira/browse/YUNIKORN-1213
> Project: Apache YuniKorn
> Issue Type: Improvement
> Components: core - scheduler
> Reporter: Weiwei Yang
> Assignee: Saad Ur Rahman
> Priority: Major
> Labels: pull-request-available
>
> YUNIKORN-1107 adds a background running health checker to verify the
> scheduler data correctness in the fixed time interval 30s:
> https://github.com/apache/yunikorn-core/blob/3ba91fb8a41c0fd0dd6243326e583dea5167199f/pkg/scheduler/health_checker.go#L34.
> We need to make this configurable, either let the user set a longer/shorter
> interval, or completely disable it.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
