Hi Evgeny,

if I understand the bug report and the commit correctly this is a problem with 
some test suite for NetBeans, not with NetBeans itself.

I don’t think we can reliably support scenarios where people add their own 
versions of JDK classes in the class path. This has to be fixed in the NetBeans 
test suite.

Cheers,
-marc




> On 17. Jan 2020, at 23:45, Evgeny Mandrikov <[email protected]> wrote:
> 
> Hi Andreas,
> 
> On Wednesday, January 15, 2020 at 11:15:49 AM UTC+1, Andreas Sewe wrote:
> you're welcome. And thanks for being always super-responsive. I wish all 
> OSS projects were like that. 
> 
> First of all thank you for these warm words!
> 
> Maybe we can replace
> 
> try {
>     Class.forName("java.lang.Module");
> } catch (final ClassNotFoundException e)
> 
> by
> 
> try {
>     Instrumentation.class.getMethod("redefineModule");
> } catch (final NoSuchMethodException e) {
> 
> However
> dummy java.lang.Module was added to NetBeans by commit 
> https://github.com/apache/netbeans/commit/4325e6ca3600c7234072df38ce50ff8c69172343
> and causes the same
> 
> java.lang.SecurityException: Prohibited package name: java.lang
> 
> on JVM 8 for example for
> 
> org.netbeans.NbInstrumentation.class.getMethods()
> 
> I strongly believe that org.netbeans.NbInstrumentation should not implement 
> java.lang.instrument.Instrumentation
> and this will allow to remove dummy java.lang.Module
> 
> Marc, WDYT?
> 
> 
> Regards,
> Evgeny
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "JaCoCo and EclEmma Users" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to [email protected] 
> <mailto:[email protected]>.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jacoco/8f5c5b96-c8f3-491b-9938-bde0a036ab69%40googlegroups.com
>  
> <https://groups.google.com/d/msgid/jacoco/8f5c5b96-c8f3-491b-9938-bde0a036ab69%40googlegroups.com?utm_medium=email&utm_source=footer>.

-- 
You received this message because you are subscribed to the Google Groups 
"JaCoCo and EclEmma Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jacoco/620669C0-C8C7-4D39-AFA5-E9D34679A407%40mountainminds.com.

Reply via email to