On 11.06.19 01:03, Ralf Ramsauer wrote:
MMIO access tests use the same test pattern. Let's share the code.
Later, we will also reuse it for other tests.

Instead of EXPECT_EQUAL, provide macros that differ between the actual
type (u8, u16, u32, u64). We can still use the same evaluation function
if we first narrow down types, and later expand them again.

I don't get the pattern yet: You introduce new macros that type-cast to the size
we want to compare. Still, quite a few call-sites carry their own casts.

Let's split this up: Part one is the factoring out, part two the type changes.

Jan

--
You received this message because you are subscribed to the Google Groups 
"Jailhouse" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jailhouse-dev/50bfa063-2952-601f-f873-e1fe28185c4d%40web.de.
For more options, visit https://groups.google.com/d/optout.

Reply via email to