On 6/11/19 5:56 PM, Jan Kiszka wrote: > On 11.06.19 01:03, Ralf Ramsauer wrote: >> MMIO access tests use the same test pattern. Let's share the code. >> Later, we will also reuse it for other tests. >> >> Instead of EXPECT_EQUAL, provide macros that differ between the actual >> type (u8, u16, u32, u64). We can still use the same evaluation function >> if we first narrow down types, and later expand them again. > > I don't get the pattern yet: You introduce new macros that type-cast to > the size > we want to compare. Still, quite a few call-sites carry their own casts. > > Let's split this up: Part one is the factoring out, part two the type > changes.
Just rebased the series. Factoring out things is sufficient. With my MMIO patches, many typecasts were replaced by bitmasks which makes those macros useless. Ralf > > Jan > -- You received this message because you are subscribed to the Google Groups "Jailhouse" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jailhouse-dev/e208129a-7261-e6eb-f146-2b9f538fa0f3%40oth-regensburg.de. For more options, visit https://groups.google.com/d/optout.
