On Sun, Mar 21, 2010 at 1:37 AM, Rob Hamerling <[email protected]>wrote:
> > Hi Joep, > > > On 03/21/10 08:43 am, Joep Suijs wrote: > > >> Enclosed version0.99a of the starters guide. >> > > Reading was at low priority with me, but I just had a look. > In general I like contents and style! > I have a few minor comments, mainline about language (although English is > not my native language, so I maybe wrong!) > > (Page references are to the A4 document) > > The document contains to many times 'by now'! Please make some variations. > > Also 'next' is used too frequently, and in some cases it should be replaced > by 'following'. Use 'next' when referring to a single item and 'following' > when referring to a list of items. > > On several places in the document you use 'that', where I think 'which' > should be used, like: > > Page 11 just below the middle: > > The right hand reference ‘led’ reads the value of led (0 or 1), the >> exclamation point inverts the value (so 0 becomes 1 and 1 becomes 0) >> and the result is the new value _that_ is assigned to the IO pin by the >> left hand reference to ‘led'. >> > > The last part is rather difficult to read anyway. Try to avoid long > sentences where these can easily be splitted, for example: > > The right hand reference ‘led’ takes the value of led (0 or 1), the > exclamation point inverts the value (so 0 becomes 1 and 1 becomes 0). > The result (the inversion of the original) is assigned to the I/O-pin by > the left hand reference to ‘led'. > > I would also use 'I/O-pin' in stead of 'IO pin' > (the '/' is an abbreviation of 'or': a pin is either input or output) > > > p 12 (about MSB): > > I think 'MSB' stands for Most Significant Byte and 'msb' for most > significant bit. See > http://en.wikipedia.org/wiki/Most_significant_bit > > Something similar for 'LSB' and 'lsb' > > > p 13 (top about nibbles): > > Variables with ‘_low’ map to the lower 4 bits of a register >> > > and the variables with ‘_high’ map to the higher 4 bits. > > I would reword that as follows: > > Variables with ‘_low’ map to the 4 low order bits of a register > (bits 3..0) and the variables with ‘_high’ map to the 4 high-order bits > (bits 7..4). > > p 14 (top) > > 'convertor' should be 'converter' > :) > > Maybe more later. > > Regards, Rob. > > > -- > Rob Hamerling, Vianen, NL (http://www.robh.nl/) > > > -- > You received this message because you are subscribed to the Google Groups > "jallib" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]<jallib%[email protected]> > . > For more options, visit this group at > http://groups.google.com/group/jallib?hl=en. > > -- You received this message because you are subscribed to the Google Groups "jallib" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/jallib?hl=en.
