> const byte GLCD_BACKGROUND_COLOR = 0 -- white > const GLCD_PEN_COLOR = 1 -- black
It is only the comment that may be incorrect, depending on the LCD. I only suggest to remove the comment. > Maybe the variables could be optimized a little more like some sbyte*3, > some sword. But is it really so helpful? The variables are local to the > procedure, so the RAM can be re-used outside the procedure. It is not only about RAM usage, but also speed. It is not a major difference so don't worry about it. > Another option: we could introduce a 'GLCD_CLIPPING' constant or > variable, which allows the user to select between clipping and no > clipping. When not declared by the user it should be declared in > glcd_common and set to FALSE by default. This matches the old situation > (before I added clipping), and it is appropriate for displays which have > the clipping function built-in. A 'GLCD_CLIPPING' constant seems like a great idea. I only complain because a LCD like mine is slow as it is, and differences like this could be quite noticeable to the user. Matt. -- You received this message because you are subscribed to the Google Groups "jallib" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/jallib?hl=en.
