Harmeet Bedi wrote: [...]
<sigh>I have still not heard if the person who has broken NNTP if he intends to fix it. My tests tell me the bug fix reverses a regression that was caused by the above mentioned checkin but does not fix the bug (. I wish the (ir)responsible developer would fix the bug rather than throw something over the fence via an indirect channel without testing(again).
You sound like a boss, not like a peer in an opensource project.
Harmeet, do you really think that pointing fingers will make things better? Who do you think you are?
This is not fair. It is ~ 3:00 on a Friday night. I am trying to testYeah, nothing should ever be broken, but it happens.
stuff that should not have broken in the first place.
You know what they use to make this not happen in OpenSource projects, where everyone contributes *freely* and in its free time?
Gump runs, unit tests and peer review.
Peer review: every commit on a project should be reviewed by other committers. Why did the bug get in? Nobody looked at it? Then the news stuff is not a community effort and should be moved to a scratchpad.
Unit tests: the code should be unit tested to make regressions not happen. Do you really think that developers that touch code after 1-2 years since the original author looked at it can still make perfect changes? There must be unit tests that do the checks. Making a correct unit test run is the *only* reasonable thing you can ask another developer to do.
Gump runs: Gump does builds and unit tests 4 times a day, and notifies the list of problems once a day. If there were unit tests run by Gump, this would have never happened.
Why? Why must *he* fix it? Just fix it, why must *he* do it? It's not *his* code, isn't it?I could have in less time fixed the server. I am testing, explaining mostly to get everybody on board and give the unnamed contributor a chance to fix this.
Then do it, the only question is about the 2.1 release, not about making someone else do it.This explaining actions to death is a direct result of the friction in James over the last few months. I don't think I would have any need to explain as much earlier, would have just fixed it.
--
Nicola Ken Barozzi [EMAIL PROTECTED]
- verba volant, scripta manent -
(discussions get forgotten, just code remains)
---------------------------------------------------------------------
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
