[ https://issues.apache.org/jira/browse/LUCENE-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746904#action_12746904 ]
Shai Erera commented on LUCENE-1849: ------------------------------------ But then what will classes like TopFieldCollector and TopScoreDocCollector will do? They won't be able to extend from any of them because a Collector may support both, one impl more efficient than the other. Of course it doesn't mean that every Collector needs to extend either of these, but I wonder if it's such a big deal to decide on your own, once you've decided to write a Collector, if you support it or not. Those two do not do any harm, but we'll just need to maintain them going forward, and I wonder if they are really that useful ... > Add OutOfOrderCollector and InOrderCollector subclasses of Collector > -------------------------------------------------------------------- > > Key: LUCENE-1849 > URL: https://issues.apache.org/jira/browse/LUCENE-1849 > Project: Lucene - Java > Issue Type: Wish > Components: Search > Affects Versions: 2.9 > Reporter: Tim Smith > Priority: Minor > Fix For: 2.9 > > > I find myself always having to implement these methods, and i always return a > constant (depending on if the collector can handle out of order hits) > would be nice for these two convenience abstract classes to exist that > implemented acceptsDocsOutOfOrder() as final and returned the appropriate > value -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org