[
https://issues.apache.org/jira/browse/LUCENE-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747029#action_12747029
]
Shai Erera commented on LUCENE-1849:
------------------------------------
How would this flag reduce any "code bloat" in subclasses? They now have to
call super() in their ctors.
And TSDC and TFC will need to add a parameter to their private ctors, so that
they can pass this parameter on to TopDocsCollector, which will need to pass it
on to Collector ...
I think this will get pretty messy and complicated.
What exactly are we trying to solve here? 5 lines of code that every Collector
developer (how many are out there anyway?) need to invest 3 minutes thinking
about them before he codes that method?
> Add OutOfOrderCollector and InOrderCollector subclasses of Collector
> --------------------------------------------------------------------
>
> Key: LUCENE-1849
> URL: https://issues.apache.org/jira/browse/LUCENE-1849
> Project: Lucene - Java
> Issue Type: Wish
> Components: Search
> Affects Versions: 2.9
> Reporter: Tim Smith
> Priority: Minor
> Fix For: 2.9
>
>
> I find myself always having to implement these methods, and i always return a
> constant (depending on if the collector can handle out of order hits)
> would be nice for these two convenience abstract classes to exist that
> implemented acceptsDocsOutOfOrder() as final and returned the appropriate
> value
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
