[ 
https://issues.apache.org/jira/browse/LUCENE-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746971#action_12746971
 ] 

Michael McCandless commented on LUCENE-1849:
--------------------------------------------

bq. I like the idea of this flag being private final and initialized via a 
Collector constructor

This seems OK to me.

bq. Collector.acceptDocsOutOfOrder() should then be made final though?

Or just make it package private?  This flag is only used by oal.search.* to 
mate the right scorer to the collector.

> Add OutOfOrderCollector and InOrderCollector subclasses of Collector
> --------------------------------------------------------------------
>
>                 Key: LUCENE-1849
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1849
>             Project: Lucene - Java
>          Issue Type: Wish
>          Components: Search
>    Affects Versions: 2.9
>            Reporter: Tim Smith
>            Priority: Minor
>             Fix For: 2.9
>
>
> I find myself always having to implement these methods, and i always return a 
> constant (depending on if the collector can handle out of order hits)
> would be nice for these two convenience abstract classes to exist that 
> implemented acceptsDocsOutOfOrder() as final and returned the appropriate 
> value

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to