[ https://issues.apache.org/jira/browse/LUCENE-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747051#action_12747051 ]
Tim Smith commented on LUCENE-1849: ----------------------------------- i was just proposing AbstractCollector to consolidate the "variations" of abstract subclasses of Collector I like ScoringCollector i would also like a NonScoringCollector in this case, i would recommend both should take the "allowDocsOutOfOrder" flag in their constructors (and store in a private final returned by acceptingOutOfOrderDocs()) otherwise, i would still want to see 2 variations on each of ScoringCollector and NonScoringCollector to handle the OutOfOrder vs InOrder variations > Add OutOfOrderCollector and InOrderCollector subclasses of Collector > -------------------------------------------------------------------- > > Key: LUCENE-1849 > URL: https://issues.apache.org/jira/browse/LUCENE-1849 > Project: Lucene - Java > Issue Type: Wish > Components: Search > Affects Versions: 2.9 > Reporter: Tim Smith > Priority: Minor > Fix For: 2.9 > > > I find myself always having to implement these methods, and i always return a > constant (depending on if the collector can handle out of order hits) > would be nice for these two convenience abstract classes to exist that > implemented acceptsDocsOutOfOrder() as final and returned the appropriate > value -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org