The FoeDeployer should register with MainDeployer as the last thing it does
in startService(), when it is in fact usable.  So at least you should move
super.startService() to the end.

I just looked at the code and think that a simpler design would be to
simply have the WLC be a SubDeployer.  You can make a common superclass
with utility methods all the foe deployers will need.  Otherwise you will
have to either give foedeployer a list of all the converters it will get,
which is kind of silly, or implement another layer of waiting behavior in
FoeDeployer, which is even sillier.  As far as I can tell from a quick
glance, FoeDeployer doesn't do anything that couldn't be done at least as
well in a superclass of WLC. Also I thought some of the file manipulation
methods were already in SubDeployerSupport??  I havne't looked at it for a
while though.

thanks
david jencks

On 2002.05.24 09:53:33 -0400 Alex Loubyansky wrote:
> Hello David,
> 
> I asked that because I found it strange that the deployer not being
> started already deploys some units, if the log is right. So, the log
> is like:
> [FoeDeployer] Starting
> [MainDeployer] Adding deployer: ....
> [MainDeployer] Starting deployment of package: <waitinig unit>
> [FoeDeployer] create()....
> ...
> [FoeDeployer] Started
> 
> when I expected it like this:
> [FoeDeployer] Starting
> [FoeDeployer] Started
> [MainDeployer] Adding deployer: ....
> [MainDeployer] Starting deployment of package: <waitinig unit>
> [FoeDeployer] create()....
> ...
> 
> Am I wrong?
> 
> Friday, May 24, 2002, 4:20:33 PM, you wrote:
> 
> DJ> From your description below I think FoeDeployer depends on
> DJ> WebLogicConverter.  If you explicitly state this dependency with a
> depends
> DJ> tag the deployment system will create WLC before FD and start WLC
> before
> DJ> FD.  If FD is designed to accept lots of converters you can use a
> DJ> depends-list element.
> 
> DJ> How does FD know about WLC now?  I'd recommend using an ObjectName
> and
> DJ> calling through the mbean server.
> 
> DJ> If you want to allow dynamically adding converters you will have to
> make FD
> DJ> keep a list of undeployables that it tries to deploy whenever a new
> DJ> converter is registered.  I don't think I recommend this.
> 
> DJ> david jencks
> 
> 
> -- 
> Best regards,
>  Alex Loubyansky
> 
> 
> 
> 

_______________________________________________________________

Don't miss the 2002 Sprint PCS Application Developer's Conference
August 25-28 in Las Vegas -- http://devcon.sprintpcs.com/adp/index.cfm

_______________________________________________
Jboss-development mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/jboss-development

Reply via email to