Hi David

> The FoeDeployer should register with MainDeployer as the last thing it
does
> in startService(), when it is in fact usable.  So at least you should move
> super.startService() to the end.

Done.

> I just looked at the code and think that a simpler design would be to
> simply have the WLC be a SubDeployer.  You can make a common superclass
> with utility methods all the foe deployers will need.

Maybe that is the way to go. I think before we make that decision we have
to decide on how the Convetor is chosen to deploy/convert because I don't
like the idea of the ".wlar" extension. This was just a wor-around to go on
now.

> Otherwise you will
> have to either give foedeployer a list of all the converters it will get,
> which is kind of silly, or implement another layer of waiting behavior in
> FoeDeployer, which is even sillier.  As far as I can tell from a quick
> glance, FoeDeployer doesn't do anything that couldn't be done at least as
> well in a superclass of WLC.
Agreed.

> Also I thought some of the file manipulation
> methods were already in SubDeployerSupport??  I havne't looked at it for a
> while though.

I didn't found any.

Andy



_______________________________________________________________

Don't miss the 2002 Sprint PCS Application Developer's Conference
August 25-28 in Las Vegas -- http://devcon.sprintpcs.com/adp/index.cfm

_______________________________________________
Jboss-development mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/jboss-development

Reply via email to