Hi Stephen, 

I really appreciate your quick responses,

>> It's when you then end up down at 
https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/model/Queue.java#L1525-L1526
 that 
the issues start cropping up.

I am not quite sure what you mean 'issues start cropping up' , what would 
happen?. I've walked through the code but I still don't see where 
'concurrent mod exception' could be happening, perhaps you mean something 
else? For my plugin there is no chance that build would be assigned to a 
phantom node, if you mean that.

>> In theory, add should be safe and only remove requiring the lock... 

Would you be open to  accepting the following patch to jenkins core

Jenkins.getInstance().addNodeWithoutQueueLock( node) 


Thanks again. 

Surya





-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/fe06e639-e501-4a97-ad58-74e701747733%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to