Jesse, Thanks for the reminder about that point around commenting. As an editor, I have no objections to having pre-draft discussions in whatever way contributors see fit.
As a sponsor of JEP-1, it is important to me that when a sponsor submits a JEP for "Approval as Draft", that feedback they get on _that_ PR focuses on issues that would prevent the JEP being approved as draft rather than on design or other questions. I'll add a note about this to https://github.com/jenkinsci/jep/pull/76 . -Liam On Tue, Apr 10, 2018 at 12:41 PM Baptiste Mathus <[email protected]> wrote: > 2018-04-10 16:33 GMT+02:00 R. Tyler Croy <[email protected]>: > >> (replies inline) >> >> On Tue, 10 Apr 2018, Jesse Glick wrote: >> >> > I for one would find it easier to comment on a PR, but IIRC JEP >> > editors have discouraged this for some reason???? >> > >> > >> > ???Healthness??? is not a word???it is just ???health???. >> > >> > >> > I would suggest `/metrics/evergreen/healthcheck` just return an empty >> > JSON document, or a simple ???OK??? marker by default???only listing >> things >> > that are _not_ healthy. >> >> It was my understanding that this format was simply the Dropwizard >> healthcheck >> format. >> > > Yes. Exactly. Also, though TBH I didn't test it myself yet, I expect one > can contribute healthchecks, and they'd appear there. > > That "OK" idea is already somehow available if one enables the `canPing` > configuration field. Then `curl`ing the URL will reply with just PONG and > http-200 IIRC. But I felt this was unnecessary to enable that too. > > >> >> Do you have some reasoning for this you could share? Otherwise this seems >> like >> a bit of personal preference to me, but I'm sure there's some logic I >> could be >> missing here. >> >> >> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Jenkins Developers" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/jenkinsci-dev/20180410143346.discdbodxgiudmfz%40grape.lasagna.io >> . >> For more options, visit https://groups.google.com/d/optout. >> > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/CANWgJS6FcSp_faJL5C26-xESdUrSQvw%3D40%2BGVxf-SkWM5TOvQQ%40mail.gmail.com > <https://groups.google.com/d/msgid/jenkinsci-dev/CANWgJS6FcSp_faJL5C26-xESdUrSQvw%3D40%2BGVxf-SkWM5TOvQQ%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAA0qCNxaUqBC6ckV-BE9qn%3DabQpoZqKMTE3oQ%3Di%3DGpqHkWG6Tw%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
