Updated webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8167558/webrev.01/
This updates the exclude-jmod-section plugin not to filter specific modules. Also clean up DefaultImageBuilder further and improve the exception message when it detects duplicated resource entries. Mandy > On Oct 14, 2016, at 8:28 AM, Mandy Chung <mandy.ch...@oracle.com> wrote: > > >> On Oct 14, 2016, at 5:55 AM, Alan Bateman <alan.bate...@oracle.com> wrote: >> >> On 13/10/2016 03:22, Mandy Chung wrote: >> >>> Webrev: >>> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8167558/webrev.00/ >>> >>> Header files and man pages are currently copied to the image. The header >>> files are modularized and in the following directory: >>> src/$MODULE/share/native/include >>> >>> The man page for the corresponding tool should also be modularized. >>> >>> This patch proposes to add a JMOD section for include header files and one >>> for man pages such that they should be packaged in a JMOD file of the >>> module they belong to. >> The changes to add the new section looks good, as does the options for the >> jmod tool. >> >> For jlink then --no-man-pages and --no-header-files look good (as >> demonstrated by how they are used in Images.gmk to create the JRE). I'm less >> sure about the exclude-jmod-section plugin needing the flexibility to >> exclude the resources in the man page or headers section for specific >> modules. I would be tempted to leave that out unless it is really needed. > > I think it should be rare to exclude resources in the man page or headers > section for specific modules. On the other hand, —-exclude-files can > exclude resources and that should be used in case of excluding any specific > resources. I will leave that out. > > > > Mandy >
