> On Oct 18, 2016, at 9:29 AM, Alan Bateman <alan.bate...@oracle.com> wrote:
> On 17/10/2016 19:24, Mandy Chung wrote:
>> Updated webrev:
>>   http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8167558/webrev.01/
>> This updates the exclude-jmod-section plugin not to filter specific modules. 
>>  Also clean up DefaultImageBuilder further and improve the exception message 
>> when it detects duplicated resource entries.
> This looks good, the only thing is storeFiles where I assume it could fail 
> early when there are duplicates rather than writing them and dealing with 
> FileAlreadyExistsException.

I agree we should do the validation early.  I think this should take the 
exclude plugins into consideration and whether there is a way to filter out 
duplicated resource files to allow the image be created.

I’m inclinded to keep the current jlink behavior and file a separate issue to 
follow this up.


Reply via email to