cmccabe commented on code in PR #12961:
URL: https://github.com/apache/kafka/pull/12961#discussion_r1046446539
##########
clients/src/main/java/org/apache/kafka/common/requests/LeaderAndIsrRequest.java:
##########
@@ -51,7 +51,16 @@ public static class Builder extends
AbstractControlRequest.Builder<LeaderAndIsrR
public Builder(short version, int controllerId, int controllerEpoch,
long brokerEpoch,
List<LeaderAndIsrPartitionState> partitionStates,
Map<String, Uuid> topicIds,
Collection<Node> liveLeaders) {
- super(ApiKeys.LEADER_AND_ISR, version, controllerId,
controllerEpoch, brokerEpoch);
+ super(ApiKeys.LEADER_AND_ISR, version, controllerId,
controllerEpoch, brokerEpoch, false);
Review Comment:
let's define this in terms of the other constructor to avoid duplicating the
below code. something like:
```
this(version, controllerId, controllerEpoch, brokerEpoch, false)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
