cmccabe commented on code in PR #12961:
URL: https://github.com/apache/kafka/pull/12961#discussion_r1046447468
##########
clients/src/main/resources/common/message/LeaderAndIsrRequest.json:
##########
@@ -36,7 +36,7 @@
"fields": [
{ "name": "ControllerId", "type": "int32", "versions": "0+", "entityType":
"brokerId",
"about": "The current controller ID." },
- { "name": "KRaftControllerId", "type": "int32", "versions": "7+",
"entityType": "brokerId", "default": "-1",
+ { "name": "KRaftControllerId", "type": "int32", "versions": "7+",
"default": "-1", "entityType": "brokerId", "default": "-1",
Review Comment:
this already has a default value of -1. It doesn't need to be stated twice...
##########
clients/src/main/resources/common/message/StopReplicaRequest.json:
##########
@@ -31,7 +31,7 @@
"fields": [
{ "name": "ControllerId", "type": "int32", "versions": "0+", "entityType":
"brokerId",
"about": "The controller id." },
- { "name": "KRaftControllerId", "type": "int32", "versions": "4+",
"entityType": "brokerId", "default": "-1",
+ { "name": "KRaftControllerId", "type": "int32", "versions": "4+",
"default": "-1", "entityType": "brokerId", "default": "-1",
Review Comment:
this already has a default value of -1. It doesn't need to be stated twice...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
