cmccabe commented on code in PR #12961:
URL: https://github.com/apache/kafka/pull/12961#discussion_r1046447035
##########
clients/src/main/java/org/apache/kafka/common/requests/StopReplicaRequest.java:
##########
@@ -45,14 +45,23 @@ public static class Builder extends
AbstractControlRequest.Builder<StopReplicaRe
public Builder(short version, int controllerId, int controllerEpoch,
long brokerEpoch,
boolean deletePartitions, List<StopReplicaTopicState>
topicStates) {
- super(ApiKeys.STOP_REPLICA, version, controllerId,
controllerEpoch, brokerEpoch);
+ super(ApiKeys.STOP_REPLICA, version, controllerId,
controllerEpoch, brokerEpoch, false);
Review Comment:
this is another case where we should define this in terms of the other
constructor to avoid duplication
```
this(version, controllerId, controllerEpoch, brokerEpoch, deletePartitions,
topicStates, false)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
