dajac commented on code in PR #13378:
URL: https://github.com/apache/kafka/pull/13378#discussion_r1133562845
##########
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorConcurrencyTest.scala:
##########
@@ -295,8 +295,12 @@ class GroupCoordinatorConcurrencyTest extends
AbstractCoordinatorConcurrencyTest
}
}
- class CommitTxnOffsetsOperation(lock: Option[Lock] = None) extends
CommitOffsetsOperation {
- override def runWithCallback(member: GroupMember, responseCallback:
CommitOffsetCallback): Unit = {
+ class CommitTxnOffsetsOperation(lock: Option[Lock] = None) extends
GroupOperation[TxnCommitOffsetCallbackParams, TxnCommitOffsetCallback] {
Review Comment:
Are there any downsides of updating the transactional offset commit as well?
I can't think of any.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
