Hangleton commented on code in PR #13378: URL: https://github.com/apache/kafka/pull/13378#discussion_r1133751522
########## core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala: ########## @@ -469,11 +469,11 @@ class GroupMetadataManager(brokerId: Int, if (isTxnOffsetCommit) { group.inLock { addProducerGroup(producerId, group.groupId) - group.prepareTxnOffsetCommit(producerId, offsetMetadata) + group.prepareTxnOffsetCommit(producerId, offsetMetadata.map { case(k, v) => k.topicPartition -> v }) } } else { group.inLock { - group.prepareOffsetCommit(offsetMetadata) + group.prepareOffsetCommit(offsetMetadata.map { case(k, v) => k.topicPartition -> v }) Review Comment: Alternatively, a forward-looking approach would be to update all public methods of `GroupMetadata` to `TopicIdPartition` although that would mean drastically extending the scope to all callers beyond the offset commit path and using the zero topic id where required. I guess this wouldn't be advisable though? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org