[GitHub] [kafka] dajac commented on a diff in pull request #13378: KAFKA-14793 - Propagate Topic Ids to the Group Coordinator during Offsets Commit

[via GitHub]

dajac commented on code in PR #13378:
URL: https://github.com/apache/kafka/pull/13378#discussion_r1133769199


##########
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##########
@@ -469,11 +469,11 @@ class GroupMetadataManager(brokerId: Int,
           if (isTxnOffsetCommit) {
             group.inLock {
               addProducerGroup(producerId, group.groupId)
-              group.prepareTxnOffsetCommit(producerId, offsetMetadata)
+              group.prepareTxnOffsetCommit(producerId, offsetMetadata.map { 
case(k, v) => k.topicPartition -> v })
             }
           } else {
             group.inLock {
-              group.prepareOffsetCommit(offsetMetadata)
+              group.prepareOffsetCommit(offsetMetadata.map { case(k, v) => 
k.topicPartition -> v })

Review Comment:
   I would only change the ones related to the offset commit path 
(transactional and non-transactional) for now. Later one, I think that we may 
have to change the ones related to the fetch path as well because we will have 
the same issues.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org