jolshan commented on code in PR #13901:
URL: https://github.com/apache/kafka/pull/13901#discussion_r1248092632
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java:
##########
@@ -568,5 +568,20 @@ public void testMetadataRefreshDeadline() {
assertTrue(group.hasMetadataExpired(time.milliseconds()));
assertEquals(time.milliseconds() + 1000,
group.metadataRefreshDeadline().deadlineMs);
assertEquals(group.groupEpoch() + 1,
group.metadataRefreshDeadline().epoch);
+
+ // Set the refresh deadline.
+ group.setMetadataRefreshDeadline(time.milliseconds() + 1000,
group.groupEpoch());
Review Comment:
when we set the refresh deadline, there is no check on the group epoch.
Maybe it's fine that we went backwards an epoch, but I'm not sure which
scenario this would be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
