dajac commented on code in PR #13901:
URL: https://github.com/apache/kafka/pull/13901#discussion_r1248096864


##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java:
##########
@@ -568,5 +568,20 @@ public void testMetadataRefreshDeadline() {
         assertTrue(group.hasMetadataExpired(time.milliseconds()));
         assertEquals(time.milliseconds() + 1000, 
group.metadataRefreshDeadline().deadlineMs);
         assertEquals(group.groupEpoch() + 1, 
group.metadataRefreshDeadline().epoch);
+
+        // Set the refresh deadline.
+        group.setMetadataRefreshDeadline(time.milliseconds() + 1000, 
group.groupEpoch());

Review Comment:
   this could for instance if the write is lost so the new epoch would not be 
known anymore.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to