[GitHub] [kafka] dajac commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

[via GitHub]

dajac commented on code in PR #13901:
URL: https://github.com/apache/kafka/pull/13901#discussion_r1248133399


##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java:
##########
@@ -568,5 +568,20 @@ public void testMetadataRefreshDeadline() {
         assertTrue(group.hasMetadataExpired(time.milliseconds()));
         assertEquals(time.milliseconds() + 1000, 
group.metadataRefreshDeadline().deadlineMs);
         assertEquals(group.groupEpoch() + 1, 
group.metadataRefreshDeadline().epoch);
+
+        // Set the refresh deadline.
+        group.setMetadataRefreshDeadline(time.milliseconds() + 1000, 
group.groupEpoch());

Review Comment:
   Yeah, you’re right. I actually use the current group epoch here because 
hasMetadataExpired would be true if epoch + 1.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org