jolshan commented on code in PR #13901:
URL: https://github.com/apache/kafka/pull/13901#discussion_r1248094484


##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java:
##########
@@ -564,9 +564,9 @@ public void testMetadataRefreshDeadline() {
         assertTrue(group.hasMetadataExpired(time.milliseconds()));
 
         // Set the refresh time deadline with a higher group epoch.
-        group.setMetadataRefreshDeadline(time.milliseconds() + 1000, 
group.groupEpoch() + 1);

Review Comment:
   why did we remove +1000? Wouldn't a deadline set to the current time be 
expired anyway (regardless of epoch)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to